How can I unzip files in Go efficiently and prevent common errors?-Golang-php.cn

How can I unzip files in Go efficiently and prevent common errors?

Linda Hamilton

Release： 2024-11-11 06:41:02

Original

885 people have browsed it

How can I unzip files in Go efficiently and prevent common errors?

Unzip Files Effortlessly with Go

Unzipping files in Go should be a breeze, but sometimes you encounter obstacles. Let's explore a straightforward solution to unzip files effectively.

Initial Code:

You presented the following code snippet:

func Unzip(src, dest string) error {
    r, err := zip.OpenReader(src)
    if err != nil {
        return err
    }
    defer r.Close()

    for _, f := range r.File {
        rc, err := f.Open()
        if err != nil {
            return err
        }
        defer rc.Close()

        path := filepath.Join(dest, f.Name)
        if f.FileInfo().IsDir() {
            os.MkdirAll(path, f.Mode())
        } else {
            f, err := os.OpenFile(
                path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, f.Mode())
            if err != nil {
                return err
            }
            defer f.Close()

            _, err = io.Copy(f, rc)
            if err != nil {
                return err
            }
        }
    }

    return nil
}

Copy after login

Optimized Solution:

To improve upon the initial code, consider the following enhancements:

func Unzip(src, dest string) error {
    r, err := zip.OpenReader(src)
    if err != nil {
        return err
    }
    defer func() {
        if err := r.Close(); err != nil {
            panic(err)
        }
    }()

    os.MkdirAll(dest, 0755)

    // Closure to address file descriptors issue
    extractAndWriteFile := func(f *zip.File) error {
        rc, err := f.Open()
        if err != nil {
            return err
        }
        defer func() {
            if err := rc.Close(); err != nil {
                panic(err)
            }
        }()

        path := filepath.Join(dest, f.Name)

        // Check for ZipSlip (Directory traversal)
        if !strings.HasPrefix(path, filepath.Clean(dest) + string(os.PathSeparator)) {
            return fmt.Errorf("illegal file path: %s", path)
        }

        if f.FileInfo().IsDir() {
            os.MkdirAll(path, f.Mode())
        } else {
            os.MkdirAll(filepath.Dir(path), f.Mode())
            f, err := os.OpenFile(path, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, f.Mode())
            if err != nil {
                return err
            }
            defer func() {
                if err := f.Close(); err != nil {
                    panic(err)
                }
            }()

            _, err = io.Copy(f, rc)
            if err != nil {
                return err
            }
        }
        return nil
    }

    for _, f := range r.File {
        err := extractAndWriteFile(f)
        if err != nil {
            return err
        }
    }

    return nil
}

Copy after login

Improvements:

Destination Directory Creation: If the destination directory doesn't exist, it's created before unzipping.
Closure for File Descriptors: To avoid defer stack issues, a closure wraps the file extraction and writing process.
ZipSlip Prevention: A check ensures extracted files stay within the designated destination folder.
Error Handling: Close() operations are handled with error panic() for best practices.

The above is the detailed content of How can I unzip files in Go efficiently and prevent common errors?. For more information, please follow other related articles on the PHP Chinese website!