Detailed explanation of C language queue issues under Linux

Recently I wrote a program that used the queue operation of the C language under the Linux system, so I had the following question
The following is the code of the queue:
This queue header file

extern struct pqueue Que;

/*构造一个空队列*/
extern pQueue *InitQueue();

/*销毁一个队列*/
extern void DestroyQueue(pQueue *pqueue);

/*清空一个队列*/
extern void ClearQueue(pQueue *pqueue);

/*判断队列是否为空*/
extern int IsEmpty(pQueue *pqueue);

/*返回队列大小*/
extern int GetSize(pQueue *pqueue);

/*返回队头元素*/
extern PNode GetFront(pQueue *pqueue,char *pitem);

/*返回队尾元素*/
extern PNode GetRear(pQueue *pqueue,char *pitem);

/*将新元素入队*/
extern PNode InQueue(pQueue *pqueue,char *pitem);

/*队头元素出队*/
extern PNode OutQueue(pQueue *pqueue,char *pitem);

The following is the queue function

struct pqueue Queue;		



	/*构造一个空队列*/

	pQueue *InitQueue()

	{

		pQueue *pqueue = (pQueue *)malloc(sizeof(Queue));

		if(pqueue!=NULL)

		{

			pqueue->front = NULL;

			pqueue->rear = NULL;

			pqueue->size = 0;

		}

		return pqueue;

	}



	/*销毁一个队列*/

	void DestroyQueue(pQueue *pqueue)

	{

		if(IsEmpty(pqueue)!=1)

			ClearQueue(pqueue);

		free(pqueue);

	}

	

	/*清空一个队列*/

	void ClearQueue(pQueue *pqueue)

	{

		while(IsEmpty(pqueue)!=1)

		{

			OutQueue(pqueue,NULL);

		}

	

	}

	

	/*判断队列是否为空*/

	int IsEmpty(pQueue *pqueue)

	{

		if(pqueue->front==NULL&&pqueue->rear==NULL&&pqueue->size==0)

			return 1;

		else

			return 0;

	}

	

	/*返回队列大小*/

	int GetSize(pQueue *pqueue)

	{

		return pqueue->size;

	}

	

	/*返回队头元素*/

	PNode GetFront(pQueue *pqueue,char *pitem)

	{

		if(IsEmpty(pqueue)!=1)

		{

			//pitem = pqueue->front->data;

		strcpy(pitem,pqueue->front->data);

		}

		return pqueue->front;

	}

	

	/*返回队尾元素*/

	

	PNode GetRear(pQueue *pqueue,char *pitem)

	{

		if(IsEmpty(pqueue)!=1)

		{

			//pitem = pqueue->rear->data;

		strcpy(pitem,pqueue->rear->data);

		}

		return pqueue->rear;

	}

	

	/*将新元素入队*/

	PNode InQueue(pQueue *pqueue,char *pitem)

	{

	//DBG0_PR("dbg QueueIn front=%d, rear=%d, count=%d\n", pqueue->front, pqueue->rear, pqueue->size);

		PNode pnode = (PNode)malloc(sizeof(Node));

		if(pnode != NULL)

		{

			strcpy(pnode->data, pitem);

			pnode->next = NULL;

	

			if(IsEmpty(pqueue))

			{

				pqueue->front = pnode;

			}

			else

			{

				pqueue->rear->next = pnode;

			}

			pqueue->rear = pnode;

			pqueue->size++;

		}

		return pnode;

	}

	

	/*队头元素出队*/

	PNode OutQueue(pQueue *pqueue,char *pitem)

	{

		PNode pnode = pqueue->front;

		if(IsEmpty(pqueue)!=1 && pnode!=NULL)

		{

			if(pitem!=NULL)

				strcpy(pitem,pnode->data);

			//pitem = pnode->data;

			pqueue->front = pnode->next;

			free(pnode);

			pqueue->size = pqueue->size - 1;

			if(pqueue->size == 0 ){

				pqueue->rear = NULL;

			}

		}

		return pqueue->front;

	}

The problem when using the queue's outque is described as follows:
For the enqueue operation, the queue size is 1, and for the dequeue operation, the queue size operation is 0, and then the program loops back to determine the queue size. The size value becomes 393216. I don’t know what happened after changing it for a long time.

The error message is like this

*** glibc detected ***      double free or corruption (!prev):

If any prawn has seen it, please answer or give me some ideas. I feel that I have reached a dead end. Thank you! ! ! !

Reply to discussion (solution)

Comment out part of the code. If the problem disappears, the problem lies in the commented out code.

Print the size value in real time to see which step the exception occurred

For reference only

#ifndef __PQUEUE_H__
#define __PQUEUE_H__

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define MAX_DATA_SIZE 256

typedef struct _node {
	char data[MAX_DATA_SIZE];
	struct _node* next;
} Node, *pNode;

typedef struct __pqueue {
	pNode front;
	pNode rear;
	int size;
} Queue, *pQueue;

/*构造一个空队列*/
extern pQueue InitQueue();

/*销毁一个队列*/
extern void DestroyQueue(pQueue pqueue);

/*清空一个队列*/
extern void ClearQueue(pQueue pqueue);

/*判断队列是否为空*/
extern int IsEmpty(pQueue pqueue);

/*返回队列大小*/
extern int GetSize(pQueue pqueue);

/*返回队头元素*/
extern int GetFront(pQueue pqueue, char *pitem);

/*返回队尾元素*/
extern int GetRear(pQueue pqueue, char *pitem);

/*将新元素入队*/
extern int InQueue(pQueue pqueue, char *pitem);

/*队头元素出队*/
extern int OutQueue(pQueue pqueue, char *pitem);

#endif /* __PQUEUE_H__ */

////////////////////////////////////////////////////////
#include "pqueue.h"		

#define err_log(fmt, ...) printf("[%s:%d]"fmt"\n", __FUNCTION__, __LINE__, ##__VA_ARGS__)
#define err_assert(con) { \
	if (!(con)) { \
		printf("[%s:%d]ASSERT>>> %s failed\n", __FUNCTION__, __LINE__, #con); \
		abort(); \
	} \
}
		

/*构造一个空队列*/
pQueue InitQueue()
{
	return (pQueue)calloc(1, sizeof(Queue));
}

/*销毁一个队列*/
void DestroyQueue(pQueue pqueue)
{
	err_assert(pqueue != NULL);
	
	if(!IsEmpty(pqueue))
		ClearQueue(pqueue);

	free(pqueue);
}

/*清空一个队列*/
void ClearQueue(pQueue pqueue)
{
	err_assert(pqueue != NULL);
	
	while (!IsEmpty(pqueue)) {
		OutQueue(pqueue, NULL);
	}
}

/*判断队列是否为空*/
int IsEmpty(pQueue pqueue)
{
	err_assert(pqueue != NULL);
	
	return !pqueue->size;
}

/*返回队列大小*/
int GetSize(pQueue pqueue)
{
	err_assert(pqueue != NULL);
	
	return pqueue->size;
}

/*返回队头元素*/
int GetFront(pQueue pqueue, char *pitem)
{
	err_assert(pqueue != NULL);
	
	if (IsEmpty(pqueue)) {
		return -1;
	}

	if (pitem) {
		err_assert(pqueue->front != NULL);
		strcpy(pitem, pqueue->front->data);
	}
	
	return 0;
}

/*返回队尾元素*/	
int GetRear(pQueue pqueue, char *pitem)
{
	err_assert(pqueue != NULL);
	
	if (IsEmpty(pqueue)) {
		return -1;
	}

	if (pitem) {
		err_assert(pqueue->rear != NULL);
		strcpy(pitem,pqueue->rear->data);
	}
	return 0;
}

/*将新元素入队*/
int InQueue(pQueue pqueue, char *pitem)
{
	err_assert(pqueue != NULL);
	
	pNode pnode = (pNode)calloc(1, sizeof(Node));
	if(NULL == pnode)  {
		return -1;
	}

	strcpy(pnode->data, pitem);
	pnode->next = NULL;
	if(IsEmpty(pqueue)) {
		pqueue->front = pnode;
	}
	else {
		pqueue->rear->next = pnode;
	}

	pqueue->rear = pnode;
	pqueue->size++;

	return 0;
}

/*队头元素出队*/
int OutQueue(pQueue pqueue,char *pitem)
{
	err_assert(pqueue != NULL);
	
	pNode pnode = pqueue->front;

	if (IsEmpty(pqueue)) {
		err_log("empty queue");
		return -1;
	}
	
	if (pitem)
		strcpy(pitem, pnode->data);

	pqueue->front = pnode->next;
	free(pnode);
	pqueue->size--;

	if (pqueue->size == 0 ){
		pqueue->rear = NULL;
	}

	return 0;
}

////////////////////////////////////////////////////////
#include "pqueue.h"		

int main(void)
{
	pQueue queue = NULL;

	queue = InitQueue();

	InQueue(queue, "I&#39;m ");
	InQueue(queue, "a ");
	InQueue(queue, "boy. ");

	while (!IsEmpty(queue)) {
		char buf[MAX_DATA_SIZE];
		if (OutQueue(queue, buf) < 0) {
			break;
		}
		printf("%s", buf);
	}
	
	printf("\n");
	DestroyQueue(queue);

	return 0;
}

The problem is found, it is not the queue. , I malloced a char* in a function, and then called the char* returned by the function in the thread. After using it, I freed it (at the end of the function). As a result, the above error was reported. I commented out the free sentence. It was fine after that. What I don’t understand is that I don’t know why it can’t be free

free should be placed in the function where you write malloc

*** glibc detected *** double free or corruption ( !prev):
Usually refers to operating a released object, such as:
1. The object has been released, but the object pointed to by the pointer is operated again.

2. A dynamically allocated object in multi-threading is used by two threads at the same time. One thread releases the object, while the other thread continues to operate the object.

Adding a thread synchronization should be no problem

The above is the detailed content of Detailed explanation of C language queue issues under Linux. For more information, please follow other related articles on the PHP Chinese website!