本帖最后由 A9925 于 2015-01-17 17:49:33 编辑 mvc大家都很熟, 基本的结构也很明白。
如果增加和修改用一个页面的话,势必会在view中写过多的逻辑判断,判断是增加控制层进来的,还是修改层进来的,以及,做完增加或修改后跳到哪个相应的控制层。 (这些都要在显示层给个action的值,或name属性,又或都get或post提交 这些判断来传到不同的控制层。)
给大家贴段代码看看以前旧项目的代码,哪需要提高,因为每次进到一个function中,都要不断的分析这个function是做什么的,维护起来,读代码的时间太浪费。请大家不吝赐教。
举例:控制层 //写的是修改成员 但里面有些功能不是修改成员数据,这只是一个文件,项目中其它地方的代码也都类似,甚至更多,每次进到方法里要走一遍流程才知道到底执行哪个,以及在哪跳出。 甚至跳出的地方用一个控制器的名称代替view(XXX.php) ,从而重复上边我说的,进入到又一次循环分析代码中。 维护起来很不方便。 需要怎么理这思路,以及以后注意哪方面进行提高 ,希望提些建设性的意见,谢谢。
<br />//----------------修改成员数据-------------------------------<br /> public function alterInfo()<br /> {<br /><br /><br /> $strAction = "";<br /> $teamname=$_SESSION['teamname'];<br /> if ($_GET){<br /> $inUserid = $_GET['id']; <br /> $data['userid'] = $inUserid;<br /> }<br /> if($_POST){<br /><br /> // var_dump($_POST);<br /> // die();<br /><br /><br /><br /> $userid = $_POST['userid'];<br /> $mobile = $_POST['mobile'];<br /> $realname = $_POST['realname'];<br /> $zhengjian = trim($this->input->post('zhengjian'));<br /> //$idnumber = $_POST['idnumber'];<br /> $idnumber = trim($this->input->post('idnu'));<br /> $address = $_POST['address'];<br /> $zipcode = $_POST['zipcode'];<br /> <br /> $clothsize = $_POST['clothsize'];<br /> $data['strClothOpt'] = $this->Common_model->getClothOpy($clothsize);<br /><br /><br /> $birthday = trim($this->input->post('birthday')); <br /> <br /> $passportnu = trim($this->input->post('passportnu'));<br /> $gender = trim($this->input->post('gender'));<br /><br /> if ($_FILES["idnumscan"]["error"] > 0)<br /> {<br /> $data['error'] = $_FILES["idnumscan"]["error"] . "<br />";<br /> $userpic = $_POST['idnumscans'];<br /> }<br /> else<br /> {<br /> $data['filename'] = $_FILES["idnumscan"]["name"];<br /> $data['filetype'] = $_FILES["idnumscan"]["type"];<br /> $data['filesize'] = ($_FILES["idnumscan"]["size"] / 1024) . " Kb";<br /> $data['filepath'] = $_FILES["idnumscan"]["tmp_name"];<br /> $excelname=iconv("UTF-8","gb2312", $_FILES["idnumscan"]["name"]);<br /> $userpic = $_FILES["idnumscan"]["name"];<br /> move_uploaded_file($_FILES["idnumscan"]["tmp_name"],"upload/image/".$excelname);<br /> }<br /> if($_POST['action']=="add"){<br /> $strAction = $teamname;<br /> $data['userid'] = "";<br /> //倒数第二位是奇数为男性,偶数为女性<br /> $gender = substr($idnumber,16,1)%2;<br /> //var_dump($gender);<br /> $teamid = $_SESSION['clubid'];<br /> $usertype=0;<br /> $this->load->model('Member_model');<br /> $rowIsReg = $this->Member_model->isRegistered($idnumber,$clubid);<br /> if($rowIsReg){<br /> echo "<script>alert('这个身份证号已经在该俱乐部被注册过!')</script>";<br /> //redirect(base_url()."member");<br /> }else{<br /> $res = $this->Member_model->insMember($mobile, $realname, $idnumber, $gender, $address, $zipcode, $clubid, $usertype,$userpic,$clothsize);<br /> if($res){<br /> echo "<script>alert('新队员创建完成!')</script>";<br /> redirect(base_url()."team");<br /> }<br /> }<br /> }<br /> if($_POST['action']=="alert"){<br /><br /> // var_dump($zhengjian);<br /> // die();<br /><br /><br /> $strAction = $teamname;<br /> $data['userid'] = $userid;<br /> if($idnumber!='' and $zhengjian =='1'){ //用身份证增加或修改的<br /> //倒数第二位是奇数为男性,偶数为女性<br /> $gender = substr($idnumber,16,1)%2;<br /> //var_dump($gender);<br /> $clubid = $_SESSION['clubid'];<br /> $usertype=0;<br /> $this->load->model('Member_model');<br /> $rowIsReg = $this->Member_model->isRegisteredtoo($idnumber,$clubid,$userid);<br /><br /> if($rowIsReg){<br /> echo "<script>alert('不能修改为".$idnumber.".这个身份证号已经在该俱乐部被注册过!')</script>";<br /> //redirect(base_url()."member");<br /> }else{<br /><br /> $res = $this->Member_model->alertMember($mobile, $realname, $idnumber, $gender, $address, $zipcode, $clubid, $usertype,$userpic,$clothsize,$userid,$birthday,$passportnu);<br /> if($res){<br /> echo "<script>alert('队员".$realname."数据修改成功!')</script>";<br /> redirect(base_url()."team");<br /> }<br /> }<br /> }else{ //用护照增加或修改的<br /><br /> // echo "111111111111";<br /> // die();<br /> $clubid = $_SESSION['clubid'];<br /> $usertype=0;<br /> $res = $this->Member_model->alertMemberpassportnu($mobile, $realname, $idnumber, $gender, $address, $zipcode, $clubid, $usertype,$userpic,$clothsize,$userid,$birthday,$passportnu,$gender);<br /> if($res){<br /> echo "<script>alert('队员".$realname."数据修改成功!')</script>";<br /> redirect(base_url()."team");<br /> }<br /> }<br /><br /> }<br /> $arrMember['userid'] = $userid;<br /> $arrMember['mobile'] = $mobile; <br /> $arrMember['realname'] = $realname; <br /> $arrMember['idnumber'] = $idnumber; <br /> $arrMember['address'] = $address; <br /> $arrMember['zipcode'] = $zipcode;<br /> $arrMember['userpic'] = $userpic;<br /> $arrMember['clothsize'] = $clothsize;<br /> //var_dump($arrMember);<br /> }else{<br /> //-----显示队员信息 <br /> $strAction = $_SESSION['teamname'];<br /> $arrMember = $this->Team_model->getMemberInfo($inUserid);<br /> $data['strClothOpt'] = $this->Common_model->getClothOpy($arrMember['clothsize']); <br /> }<br /> <br /> $data['straction'] = "alert";<br /> $data['arrMember'] = $arrMember;<br /> $data['strAction'] = $strAction;<br /> $this->load->view('head');<br /> $this->load->view('player',$data);<br /> $this->load->view('foot');<br /> <br /> }<br />
로그인 후 복사