【ブティックおすすめ】高品質なPHPコードのための実践的な50のヒント

define('ENVIRONMENT' , 'development'); if(! $db->query( $query ) { if(ENVIRONMENT == 'development') { echo "$query failed"; } else { echo "Database error. Please contact administrator"; } }

<?php class super_class { function super_function() { //super code } } //No closing tag

function print_header() { echo "<div id='header'>Site Log and Login links</div>"; } function print_footer() { echo "<div id='footer'>Site was made by me</div>"; } print_header(); for($i = 0 ; $i < 100; $i++) { echo "I is : $i '; }print_footer();

function print_header() { $o = "<div id='header'>Site Log and Login links</div>"; return $o; }function print_footer() { $o = "<div id='footer'>Site was made by me</div>"; return $o; }echo print_header(); for($i = 0 ; $i < 100; $i++) { echo "I is : $i '; } echo print_footer();

$xml = '<?xml version="1.0" encoding="utf-8" standalone="yes"?>'; $xml = "<response> <code>0</code> </response>";//Send xml data echo $xml;

$xml = '<?xml version="1.0" encoding="utf-8" standalone="yes"?>'; $xml = "<response> <code>0</code> </response>"; //Send xml data header("content-type: text/xml"); echo $xml;

JavaScriptheader("content-type: application/x-javascript"); echo "var a = 10"; CSSheader("content-type: text/css"); echo "#div id { background:#000; }";

//Attempt to connect to database $c = mysqli_connect($this->host , $this->username, $this->password); //Check connection validity if (!$c)  { die ("Could not connect to the database host: ". mysqli_connect_error()); } //Set the character set of the connectionif(!mysqli_set_charset ( $c , 'UTF8' )) { die('mysqli_set_charset() failed'); }

$value = htmlentities($this->value , ENT_QUOTES , CHARSET);

$images = array( 'myself.png' , 'friends.png' , 'colleagues.png' );$js_code = '';foreach($images as $image){$js_code .= "'$image' ,";}$js_code = 'var images = [' . $js_code . ']; ';echo $js_code;//Output is var images = ['myself.png' ,'friends.png' ,'colleagues.png' ,];     更聪明的做法, 使用 json_encode:     $images = array( 'myself.png' , 'friends.png' , 'colleagues.png' );$js_code = 'var images = ' . json_encode($images); echo $js_code;//Output is : var images = ["myself.png","friends.png","colleagues.png"]

$contents = "All the content";$file_path = "/var/www/project/content.txt"; file_put_contents($file_path , $contents);

$contents = "All the content"; $dir = '/var/www/project'; $file_path = $dir . "/content.txt"; if(is_writable($dir)) { file_put_contents($file_path , $contents); } else { die("Directory $dir is not writable, or does not exist. Please check"); }

// Read and write for owner, read for everybody else chmod("/somedir/somefile", 0644); // Everything for owner, read and execute for others chmod("/somedir/somefile", 0755);

if($_POST['submit'] == 'Save') { //Save the things }

if( $_SERVER['REQUEST_METHOD'] == 'POST' and isset($_POST['submit']) ) { //Save the things }

//Delay for some time function delay() { $sync_delay = get_option('sync_delay'); echo "Delaying for $sync_delay seconds..."; sleep($sync_delay); echo "Done "; }

//Delay for some time function delay() { static $sync_delay = null; if($sync_delay == null) { $sync_delay = get_option('sync_delay'); } echo "Delaying for $sync_delay seconds..."; sleep($sync_delay); echo "Done "; }

$_SESSION['username'] = $username; $username = $_SESSION['username'];

define('APP_ID' , 'abc_corp_ecommerce'); //Function to get a session variable function session_get($key) { $k = APP_ID . '.' . $key; if(isset($_SESSION[$k])) { return $_SESSION[$k]; } return false; } //Function set the session variable function session_set($key , $value) { $k = APP_ID . '.' . $key; $_SESSION[$k] = $value; return true; }

function utility_a() { //This function does a utility thing like string processing }function utility_b() { //This function does nother utility thing like database processing } function utility_c() { //This function is ... }

class Utility {public static function utility_a(){}public static function utility_b() { }public static function utility_c() { } }//and call them as $a = Utility::utility_a(); $b = Utility::utility_b();

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';">if($a == true) $a_count++;</span>

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';">if($a == true) { $a_count++; }</span>

foreach($arr as $c => $v) { $arr[$c] = trim($v); }

$arr = array_map('trim' , $arr);

$amount = intval( $_GET['amount'] ); $rate = (int) $_GET['rate'];

$db_records_in_array_format; //This is a big array holding 1000 rows from a table each having 20 columns , every row is atleast 100 bytes , so total 1000 * 20 * 100 = 2MB$cc = $db_records_in_array_format; //2MB moresome_function($cc); //Another 2MB ?

$a = get_large_array(); pass_to_function(&$a);

class A { function first() { $this->a = get_large_array(); $this->pass_to_function(); } function pass_to_function() { //process $this->a } }

function add_to_cart() {$db = new Database(); $db->query("INSERT INTO cart ....."); } function empty_cart() {$db = new Database(); $db->query("DELETE FROM cart ....."); }

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';">$query = "INSERT INTO users(name , email , address , phone) VALUES('$name' , '$email' , '$address' , '$phone')"; $db->query($query); //call to mysqli_query()</span>

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';">function insert_record($table_name , $data) { foreach($data as $key => $value) { //mysqli_real_escape_string $data[$key] = $db->mres($value); } $fields = implode(',' , array_keys($data)); $values = "'" . implode("','" , array_values($data)) . "'"; //Final query $query = "INSERT INTO {$table}($fields) VALUES($values)"; return $db->query($query);} $data = array('name' => $name , 'email' => $email , 'address' => $address , 'phone' => $phone); insert_record('users' , $data);</span>

<head> <base href="http://www.domain.com/store/"> </head> <body> <img src="happy.jpg" /> </body> </html>

<a href="home.php">Home</a> <a href="products/ipad.php">Ipad</a>

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';"><a href="../home.php">Home</a> <a href="ipad.php">Ipad</a></span>

  
  <a href="home.php">Home</a> <a href="products/ipad.php">Ipad</a>  

<span style="color:#333333;font-family:'Helvetica, Arial, sans-serif';">ini_set('display_errors', 1); error_reporting(~E_WARNING & ~E_NOTICE & ~E_STRICT);</span>

<span style="color:#333333;font-family:''Helvetica, Arial, sans-serif'';">set_time_limit(30); //Rest of the code</span>

$action = isset($_REQUEST['action']) ? $_REQUEST['action'] : 0;

define('yourPage',1);

if (!defined('yourPage')) die('Access Denied');

public function dbExec($query)            {                $result = $this->db->exec($query);                if (PEAR::isError($result))                    errorRedirect($result->getMessage(), true);                else                   return $result;            }

// checks if arguments given are integer values not less than 0 - has multiple arguments            function sanitizeInput()            {                $numargs = func_num_args();                $arg_list = func_get_args();                for ($i = 0; $i < $numargs; $i++) {                    if (!is_numeric($arg_list[$i]) || $arg_list[$i] < 0)                        errorRedirect("Unexpected variable value", true);                }            }

require_once PROJECTROOT.'libs/messages.class.php';            $message = new Message();            switch ($action)          {              case 'display':                  $message->display();                  break;            ...

private function getSentMessages($id)            {           $this->util->sanitizeInput($id);               $pm_table = $GLOBALS['config']['privateMsg'];            $users = $GLOBALS['config']['users'];                $sql = "SELECT PM.*, USR.username as name_sender FROM $pm_table PM, $users USR                    WHERE id_sender = '$id' AND sender_purge = FALSE AND USR.id = PM.id_receiver AND is_read = TRUE                    ORDER BY date_sent DESC";            $result = $this->dbQueryAll($sql);               return $result;            }

function smartyObject()            {                if ($GLOBALS['config']['SmartyObj'] == 0)                {                    $smarty = new SmartyGame();                    $GLOBALS['config']['SmartyObj'] = $smarty;                }                else                   $smarty = $GLOBALS['config']['SmartyObj'];                return $smarty;            }