Developers always like to argue about coding standards, but what is more important is how to follow coding standards from beginning to end in the project to ensure the consistency of the project code. And everyone on the team needs to understand the role coding standards play. In this article, I will introduce some of the best practices that I have learned and summarized during my many years of practice.
Let’s first look at a FizzBuzz example. FizzBuzz asks you to write a program that iterates through the numbers from 1 to 100. If a number is a multiple of 3, the program outputs "Fizz". If a number is a multiple of 5, output "Buzz". If a number is a multiple of both 3 and 5, output "FizzBuzz". If a number is neither a multiple of 3 nor a multiple of 5, just print the number itself.
Example 1:
public static void Test()
{
for (int i = 1; i < 101; i++)
{
if (i % 3 == 0 && i % 5 == 0)
{
Console.WriteLine("FizzBuzz");
}
else if (i % 3 == 0)
{
Console.WriteLine("Fizz");
}
else if (i % 5 == 0)
{
Console.WriteLine("Buzz");
}
else
{
Console.WriteLine(i);
}
}
}What does it feel like? Does this code need improvement?
Example 2:
public static void Check()
{
for (int i = 1; i <= 100; i++)
{
string output = "";
if (i % 3 == 0) { output = "Fizz"; }
if (i % 5 == 0) { output = output + "Buzz"; }
if (output == "") { output = i.ToString(); }
Console.WriteLine(output);
}
}How do you feel now? Can it be improved further?
Okay, let's try to improve it. Code naming is a very difficult thing for all software developers. We spent a lot of time doing this, and there were too many elements that needed to be named, such as properties, methods, classes, files, projects, etc. However, we do need to spend some effort on these names to make the names in the code more meaningful, which in turn improves the readability of the code.
public void DoFizzBuzz()
{
for (int number = 1; number <= 100; number++)
{
var output = GetFizzBuzzOutput(number);
Console.WriteLine(output);
}
}
private static string GetFizzBuzzOutput(int number)
{
string output = string.Empty;
if (number % 3 == 0)
{
output = "Fizz";
}
if (number % 5 == 0)
{
output += "Buzz";
}
if (string.IsNullOrEmpty(output))
{
output = number.ToString();
}
return output;
}How do you feel this time? Is it better than the previous example? Is it more readable?
The first is that code should be written for humans, and the second is for machines. In the long run, writing readable code won't take longer than writing confusing code. If you can easily read the code you write, it's easier to make sure it works. This should be reason enough to write readable code. You need to read code in many situations. For example, you will read the code you wrote during a code review, you will read the code you wrote when you or others fix bugs, and you will also read it when the code needs to be modified. Also, when other people are going to try to reuse part of your code in similar projects or projects with similar functions, they will also read your code first.
"If you only write code for yourself, why make the code more readable?"
Well, the main reason to write readable code is because in the next week or two, you will be working on another project. At this time, someone else needs to fix a bug in the current project, so what will happen? I guarantee he will get lost in the horrible code you wrote yourself.
From my personal point of view, good code should have the following characteristics:
The code is easy to write, and easy to modify and extend.
The code is clean and well expressed.
Code has value and focus on quality.
So, always think about writing code for people first, and then to meet the needs of machines.
First, you need to read and study the code written by other people to understand what is good code and what is bad code. That is, code that you feel is very easy to understand, and code that feels super complicated. Then, practice. Finally spend some time, experience, and practice improving the readability of your code. Generally speaking, it is difficult to promote coding standards in any software company through training alone. And tools such as paired code review and automated code review can also help you. Currently popular tools are:
FxCop: Static code analysis of .NET code, providing a variety of rules to perform different forms of analysis.
StyleCop: An open source project that uses code style and consistency specifications to analyze C# code. Can be run in Visual Studio or integrated into MSBuild. StyleCop has also been integrated into some third-party development tools.
JetBrains ReSharper: A very famous productivity tool that makes Microsoft Visual Studio IDE more powerful. .NET developers around the world may not be able to imagine how they can work without ReSharper's powerful features such as code review, automatic code refactoring, quick navigation, and coding assistants.
依据维基百科上的描述："Coding conventions are a set of guidelines for a specific programming language that recommend programming style, practices and methods for each aspect of a piece program written in this language. These conventions usually cover file organization, indentation, comments, declarations, statements, white space, naming conventions, programming practices, programming principles, programming rules of thumb, architectural best practices, etc. These are guidelines for software structural quality. Software programmers are highly recommended to follow these guidelines to help improve the readability of their source code and make software maintenance easier. Coding conventions are only applicable to the human maintainers and peer reviewers of a software project. Conventions may be formalized in a documented set of rules that an entire team or company follows, or may be as informal as the habitual coding practices of an inpidual. Coding conventions are not enforced by compilers. As a result, not following some or all of the rules has no impact on the executable programs created from the source code."。
你应该能说出属性、局部变量、方法名、类名等的不同，因为它们使用不同的大小写约定，所以这些约定非常有价值。通过互联网，你已经了解了很多相应的准则和规范，你所需要的仅是找到一种规范或者建立你自己的规范，然后始终遵循该规范。
下面使用到的源代码（类库设计准则）是由微软的 Special Interest Group 团队开发的，我只是做了些扩展。
下面是一些关于C#编码标准、命名约定和最佳实践的示例，可以根据你自己的需要来使用。
Pascal Casing
标示符中的首字母，后续串联的每个单词的首字母均为大写。如果需要，标示符的前几个字母均可大写。
Camel Casing
标示符的首字母为小写，后续串联的每个单词的首字母为大写。
参考：标示符大小写规则
在互联网上你可以找到足够多的资源，我只是推荐几个其中我最喜欢的：
C# 编码约定
C# 编码准则
C# 编码标准和最佳实践
C# 编码规范和命名约定
这里我展示了一些最基本的示例，但就像我上面已经提到的，找到一个适合你的规范，然后坚持使用。
要使用 Pascal Casing 为类和方法命名。
public class Product
{
public void GetActiveProducts()
{
//...
}
public void CalculateProductAdditinalCost()
{
//...
}
}要使用 Camel Casing 为方法的参数和局部变量命名。
public class ProductCategory
{
public void Save(ProductCategory productCategory)
{
// ...
}
}不要使用缩写语。
// Correct
ProductCategory productCategory;
// Avoid
ProductCategory prodCat;不要在标示符中使用下划线。
// Correct
ProductCategory productCategory;
// Avoid
ProductCategory product_Category;要在接口名称前使用字母 I 。
public interface IAddress
{
}要在类的顶端定义所有成员变量，在最顶端定义静态变量。
public class Product
{
public static string BrandName;
public string Name { get; set; }
public DateTime DateAvailable { get; set; }
public Product()
{
// ...
}
}要使用单数的词汇定义枚举，除非是BitField枚举。
public enum Direction
{
North,
East,
South,
West
}不要为枚举名称添加Enum后缀。
//Avoid
public enum DirectionEnum
{
North,
East,
South,
West
}在大型项目中，开发人员会常依赖于编码规范。他们建立了很多规范和准则，以至于记住这些规范和准则已经变成了日常工作的一部分。计算机并不关心你写的代码可读性是否好，比起读懂那些高级的程序语言语句，计算机更容易理解二进制的机器指令。
编码规范提供了很多明显的好处，当然有可能你得到的更多。通常这些项目整体范围的规划，将使能够将精力更多的集中在代码中更重要的部分上。
编码规范可以帮助跨项目的传递知识。
编码规范可以帮助你在新的项目上更快速的理解代码。
编码规范强调组织中关联项目间的关系。
你需要编写可读性高的代码，以此来帮助其他人来理解你的代码。代码命名对我们软件开发人员来说是件非常困难的事情，我们在这上面已经花费了大量的时间，并且有太多的需要命名的元素，例如属性、方法、类、文件、项目等。所以我们确实需要花费一些精力在命名规范上，以使名称更有意义，进而提高代码的可读性。
还有，编码规范可以让你晚上睡得更香。
我曾经看到过，并且也曾写过一些超大的类。而且不幸的是，结果总是不好的。后来我找到了真正原因，就是那些超大的类在尝试做太多的事情，这违反了单一职责原则（SRP），也就是面向对象设计原则 SOLID 中的 S。
“The single responsibility principle states that every object should have a single responsibility, and that responsibility should be entirely encapsulated by the class. All its services should be narrowly aligned with that responsibility.”
或者按照 Martin Fowler 的定义："THERE SHOULD NEVER BE MORE THAN ONE REASON FOR A CLASS TO CHANGE."
为什么一定要将两个职责分离到单独的类中呢？因为每一个职责都是变化的中心。在需求变更时，这个变更将会出现在负责该职责的类中。如果一个类承担了多个职责，就会有一个以上的原因导致其变化。如果一个类有多重职责，则说明这些职责已经耦合到了一起。并且某个职责的变化将有可能削弱或限制这个类满足其他职责的能力。这种耦合将会导致非常脆弱的设计，进而在职责发生变化时，设计可能被意想不到的破坏了。
先说什么过时的注释。按照 Robert C. Martin 的定义：
"A comment that has gotten old, irrelevant, and incorrect is obsolete. Comments get old quickly. It is best not to write a comment that will become obsolete. If you find an obsolete comment, it is best to update it or get rid of it as quickly as possible. Obsolete comments tend to migrate away from the code they once described. They become floating islands of irrelevance and misdirection in the code."
针对这个主题，不同水平的开发人员可能都会有自己的见解。我的建议是尝试避免为单独的方法或短小的类进行注释。因为我所见过的大部分的注释都是在尝试描述代码的目的或意图，或者某些注释可能本身就没什么意义。通常开发人员通过写注释来提高代码的可读性和可维护性，但要保证你所写的注释不会成为代码中的噪音。比起注释，我认为合理的方法命名将更为有效，比如你可以为一个方法起一个更有意义的名字。大部分注释都可能变成了无意义的代码噪音，让我们来看看下面这些注释：
//ensure that we are not exporting
//deleted products
if (product.IsDeleted && !product.IsExported)
{
ExportProducts = false;
}
// This is a for loop that prints the 1 million times
for (int i = 0; i < 1000000; i++)
{
Console.WriteLine(i);
}如果我们不写注释，而是命名一个方法，比如叫 CancelExportForDeletedProducts() ，情况会怎样？所以，合适的方法命名比注释更有效。然而某些情况下，代码注释也会非常有帮助，比如 Visual Studio 会从注释生成 API 文档。此处的注释略有不同，你需要使用 “///” 标识符来注释，这样其他开发人员才能看到 API 或类库的智能提示。
我没有说总是要避免注释。按照 Kent Beck 说法，可以使用更多的注释来描述程序整体是如何工作的，而不是对单独的方法进行注释。如果注释是在尝试描述代码的目的或意图，那就错了。如果你在代码中看到了密密麻麻的的注释，你可能就会意识到有这么多注释说明代码写的很糟糕。了解更多信息可以阅读下面这几本书：
《Professional Refactoring in C# and ASP.NET》 by Danijel Arsenovski
《重构：改善既有代码设计》 by Martin Fowler, Kent Beck, John Brant, William Opdyke, Don Roberts
Region 是 Visual Studio 提供的一个功能，它允许你将代码分块。Region 的存在是因为它可以使大文件导航变得容易。Region 还常被用于隐藏丑陋的代码，或者类已经膨胀的非常大了需要分块。而如果一个类做了太多的事情，也就说明其违反了单一职责原则。所以，下次当你想新增一个 Region 时，先考虑下有没有可能将这个 Region 分离到一个单独的类中。
方法中的代码行数越多，则方法越难理解。我们推荐每个方法中只包含 20-25 行代码。但有些人说 1-10 行更合理，这只是些个人喜好，没有硬性的规则。抽取方法是最常见的重构方式之一。如果你发现一个方法过长，或者已经需要一个注释来描述它的目的了，那么你就可以应用抽取方法了。人们总是会问一个方法到底多长合适，但其实长度并不是问题的根源。当你在处理复杂的方法时，跟踪所有局部变量是最复杂和消耗时间的，而通过抽取一个方法可以节省一些时间。可以使用 Visual Studio 来抽取方法，它会帮助你跟踪局部变量，并将其传递给新的方法或者接收方法的返回值。
Using ReSharper
Using Microsoft Visual Studio
更多的信息可以参考 MSDN。
按照《重构：改善既有代码设计》中的描述，
"Extract Method is one of the most common refactoring I do. I look at a method that is too long or look at code that needs a comment to understand its purpose. I then turn that fragment of code into its own method. I prefer short, well-named methods for several reasons. First, it increases the chances that other methods can use a method when the method is finely grained. Second, it allows the higher-level methods to read more like a series of comments. Overriding also is easier when the methods are finely grained. It does take a little getting used to if you are used to seeing larger methods. And small methods really work only when you have good names, so you need to pay attention to naming. People sometimes ask me what length I look for in a method. To me length is not the issue. The key is the semantic distance between the method name and the method body. If extracting improves clarity, do it, even if the name is longer than the code you have extracted."
通过声明一个类来代替多个参数。创建一个类，用于包含所有的参数。通常来讲，这是一个较好的设计，并且这个抽象非常的有价值。
//avoid
public void Checkout(string shippingName, string shippingCity,
string shippingSate, string shippingZip, string billingName,
string billingCity, string billingSate, string billingZip)
{
}
//DO
public void Checkout(ShippingAddress shippingAddress, BillingAddress billingAddress)
{
}我们需要引入类来代替所有的参数。
if(product.Price>500 && !product.IsDeleted &&
!product.IsFeatured && product.IsExported)
{
// do something
}复杂的表达式意味着其背后隐藏了一些涵义，我们可以通过使用属性来封装这些表达式，进而使代码更易读些。
如果你注意看代码，你会发现一个变量被声明了但从没被使用过。正常来讲，我们编译工程后会得到一个警告，但仍可以运行工程而不会发生任何错误。但是我们应该尽可能地移除这些警告。通过如下步骤可以在工程上设置将警告等同于错误：
在每段程序中都减少函数返回的数量。假设从底部开始阅读代码，你很难意识到有可能在上面的某处已经返回了，这样的代码将是非常难理解的。
仅使用一处返回可以增强可读性。如果程序这么写的话可能看起来比较干净，但不立即返回也意味着需要编写更多代码。
//avoid
if(product.Price>15)
{
return false;
}
else if(product.IsDeleted)
{
return false;
}
else if(!product.IsFeatured)
{
return false;
}
else if()
{
//.....
}
return true;//DO
var isValid = true;
if(product.Price>15)
{
isValid= false;
}
else if(product.IsDeleted)
{
isValid= false;
}
else if(!product.IsFeatured)
{
isValid= false;
}
return isValid;你可以想象在这 20-30 行代码中就散落了 4 个退出点，这会使你非常难理解到底程序内部做了什么，到底会执行什么，什么时候执行。
关于这一点我得到了很多人的回复，一些人同意这个观点，有些则不同意这是一个好的编码标准。为了找出潜在的问题，我做了些单元测试，发现如果复杂的方法包含多个退出点，通常情况下会需要一组测试来覆盖所有的路径。
if( BADFunction() == true)
{
// expression
if( anotherFunction() == true )
{
// expression
return true;
}
else
{
//error
}
}
else
{
//error
}
return false;if( !GoodFunction())
{
// error.
return false
}
// expression
if( !GoodFunction2())
{
//error.
return false;
}
// more expression
return true;进一步理解可以参考 Steve McConnell 的《代码大全》。
在软件开发中，断言代码常被用于检查程序代码是否按照其设计在执行。通常 True 代表所有操作按照预期的完成，False 代表已经侦测到了一些意外的错误。断言通常会接收两个参数，一个布尔型的表达式用于一个描述假设为真的假定，一个消息参数用于描述断言失败的原因。
尤其在开发大型的、复杂的高可靠系统中，断言通常是非常有用的功能。
例如：如果系统假设将最多支持 100,000 用户记录，系统中可能会包含一个断言来检查用户记录数小于等于 100,000，在这种范围下，断言不会起作用。但如果用户记录数量超过了 100,000，则断言将会抛出一个错误来告诉你记录数已经超出了范围。
一个循环通常会涉及三种条件值：第一个值、中间的某值和最后一个值。但如果你有任何其他的特定条件，也需要进行检测。如果循环中包含了复杂的计算，请不要使用计算器，要手工检查计算结果。
通常在任何软件公司中推行编码规范都需要按照组织行为、项目属性和领域来进行，在此我想再次强调“找到一个适合你的编码规范，并一直遵循它”。
如果你认为我遗漏了某个特别有用的编码准则，请在评论中描述，我会尝试补充到文章中。
Coding For Fun.
The above is the detailed content of Teach you how to write better C# code examples. For more information, please follow other related articles on the PHP Chinese website!
The difference between official replacement phone and brand new phone
What to do if the computer has no sound
What are the data analysis methods?
localhost8080 cannot access solution
How to open iso file
Solution to Permission denied
Introduction to javascript special effects code
How to change password in MySQL
![[Web front-end] Node.js quick start](https://img.php.cn/upload/course/000/000/067/662b5d34ba7c0227.png)
